Merge pull request #974 from c9s/refactor/isolation

refactor persistence for isolation

pkg/bbgo/environment.go

@@ -283,7 +283,7 @@ func (environ *Environment) ConfigurePersistence(conf *PersistenceConfig) error
 		}
 
 		redisPersistence := service.NewRedisPersistenceService(conf.Redis)
-		PersistenceServiceFacade.Redis = redisPersistence
+		persistenceServiceFacade.Redis = redisPersistence
 	}
 
 	if conf.Json != nil {
@@ -295,7 +295,7 @@ func (environ *Environment) ConfigurePersistence(conf *PersistenceConfig) error
 		}
 
 		jsonPersistence := &service.JsonPersistenceService{Directory: conf.Json.Directory}
-		PersistenceServiceFacade.Json = jsonPersistence
+		persistenceServiceFacade.Json = jsonPersistence
 	}
 
 	return nil
@@ -630,7 +630,7 @@ func (environ *Environment) ConfigureNotificationSystem(userConfig *Config) erro
 		userConfig.Notifications = &NotificationConfig{}
 	}
 
-	var persistence = PersistenceServiceFacade.Get()
+	var persistence = persistenceServiceFacade.Get()
 
 	err := environ.setupInteraction(persistence)
 	if err != nil {

pkg/bbgo/isolation.go

@@ -2,22 +2,24 @@ package bbgo
 
 import (
 	"context"
+
+	"github.com/c9s/bbgo/pkg/service"
 )
 
 const IsolationContextKey = "bbgo"
 
-var defaultIsolation *Isolation = nil
+var defaultIsolation = NewIsolation()
-
-func init() {
-	defaultIsolation = NewIsolation()
-}
 
 type Isolation struct {
-	gracefulShutdown GracefulShutdown
+	gracefulShutdown         GracefulShutdown
+	persistenceServiceFacade *service.PersistenceServiceFacade
 }
 
 func NewIsolation() *Isolation {
-	return &Isolation{}
+	return &Isolation{
+		gracefulShutdown:         GracefulShutdown{},
+		persistenceServiceFacade: DefaultPersistenceServiceFacade,
+	}
 }
 
 func NewIsolationFromContext(ctx context.Context) *Isolation {
@@ -28,3 +30,11 @@ func NewIsolationFromContext(ctx context.Context) *Isolation {
 
 	return defaultIsolation
 }
+
+func NewContextWithIsolation(parent context.Context, isolation *Isolation) context.Context {
+	return context.WithValue(parent, IsolationContextKey, isolation)
+}
+
+func NewContextWithDefaultIsolation(parent context.Context) context.Context {
+	return context.WithValue(parent, IsolationContextKey, defaultIsolation)
+}

pkg/bbgo/persistence.go

@@ -1,7 +1,7 @@
 package bbgo
 
 import (
-	"fmt"
+	"context"
 	"reflect"
 
 	log "github.com/sirupsen/logrus"
@@ -10,96 +10,21 @@ import (
 	"github.com/c9s/bbgo/pkg/service"
 )
 
-type PersistenceSelector struct {
-	// StoreID is the store you want to use.
-	StoreID string `json:"store" yaml:"store"`
-
-	// Type is the persistence type
-	Type string `json:"type" yaml:"type"`
-}
-
 var DefaultPersistenceServiceFacade = &service.PersistenceServiceFacade{
 	Memory: service.NewMemoryService(),
 }
 
-var PersistenceServiceFacade = DefaultPersistenceServiceFacade
+var persistenceServiceFacade = DefaultPersistenceServiceFacade
-
-// Persistence is used for strategy to inject the persistence.
-type Persistence struct {
-	PersistenceSelector *PersistenceSelector `json:"persistence,omitempty" yaml:"persistence,omitempty"`
-}
-
-func (p *Persistence) backendService(t string) (service.PersistenceService, error) {
-	switch t {
-	case "json":
-		return PersistenceServiceFacade.Json, nil
-
-	case "redis":
-		if PersistenceServiceFacade.Redis == nil {
-			log.Warn("redis persistence is not available, fallback to memory backend")
-			return PersistenceServiceFacade.Memory, nil
-		}
-		return PersistenceServiceFacade.Redis, nil
-
-	case "memory":
-		return PersistenceServiceFacade.Memory, nil
-
-	}
-
-	return nil, fmt.Errorf("unsupported persistent type %s", t)
-}
-
-func (p *Persistence) Load(val interface{}, subIDs ...string) error {
-	ps, err := p.backendService(p.PersistenceSelector.Type)
-	if err != nil {
-		return err
-	}
-
-	log.Debugf("using persistence store %T for loading", ps)
-
-	if p.PersistenceSelector.StoreID == "" {
-		p.PersistenceSelector.StoreID = "default"
-	}
-
-	store := ps.NewStore(p.PersistenceSelector.StoreID, subIDs...)
-	return store.Load(val)
-}
-
-func (p *Persistence) Save(val interface{}, subIDs ...string) error {
-	ps, err := p.backendService(p.PersistenceSelector.Type)
-	if err != nil {
-		return err
-	}
-
-	log.Debugf("using persistence store %T for storing", ps)
-
-	if p.PersistenceSelector.StoreID == "" {
-		p.PersistenceSelector.StoreID = "default"
-	}
-
-	store := ps.NewStore(p.PersistenceSelector.StoreID, subIDs...)
-	return store.Save(val)
-}
-
-func (p *Persistence) Sync(obj interface{}) error {
-	id := dynamic.CallID(obj)
-	if len(id) == 0 {
-		return nil
-	}
-
-	ps := PersistenceServiceFacade.Get()
-	return storePersistenceFields(obj, id, ps)
-}
 
 // Sync syncs the object properties into the persistence layer
-func Sync(obj interface{}) {
+func Sync(ctx context.Context, obj interface{}) {
 	id := dynamic.CallID(obj)
 	if len(id) == 0 {
 		log.Warnf("InstanceID() is not provided, can not sync persistence")
 		return
 	}
 
-	ps := PersistenceServiceFacade.Get()
+	ps := persistenceServiceFacade.Get()
 	err := storePersistenceFields(obj, id, ps)
 	if err != nil {
 		log.WithError(err).Errorf("persistence sync failed")

pkg/bbgo/trader.go

@@ -376,11 +376,11 @@ func (trader *Trader) LoadState() error {
 		return nil
 	}
 
-	if PersistenceServiceFacade == nil {
+	if persistenceServiceFacade == nil {
 		return nil
 	}
 
-	ps := PersistenceServiceFacade.Get()
+	ps := persistenceServiceFacade.Get()
 
 	log.Infof("loading strategies states...")
 
@@ -413,11 +413,11 @@ func (trader *Trader) SaveState() error {
 		return nil
 	}
 
-	if PersistenceServiceFacade == nil {
+	if persistenceServiceFacade == nil {
 		return nil
 	}
 
-	ps := PersistenceServiceFacade.Get()
+	ps := persistenceServiceFacade.Get()
 
 	log.Infof("saving strategies states...")
 	return trader.IterateStrategies(func(strategy StrategyID) error {
@@ -434,16 +434,7 @@ func (trader *Trader) Shutdown(ctx context.Context) {
 	trader.gracefulShutdown.Shutdown(ctx)
 }
 
-var defaultPersistenceSelector = &PersistenceSelector{
-	StoreID: "default",
-	Type:    "memory",
-}
-
 func (trader *Trader) injectCommonServices(s interface{}) error {
-	persistence := &Persistence{
-		PersistenceSelector: defaultPersistenceSelector,
-	}
-
 	// a special injection for persistence selector:
 	// if user defined the selector, the facade pointer will be nil, hence we need to update the persistence facade pointer
 	sv := reflect.ValueOf(s).Elem()
@@ -455,7 +446,7 @@ func (trader *Trader) injectCommonServices(s interface{}) error {
 				return fmt.Errorf("field Persistence is not a struct element, %s given", field)
 			}
 
-			if err := dynamic.InjectField(elem, "Facade", PersistenceServiceFacade, true); err != nil {
+			if err := dynamic.InjectField(elem, "Facade", persistenceServiceFacade, true); err != nil {
 				return err
 			}
 
@@ -475,7 +466,6 @@ func (trader *Trader) injectCommonServices(s interface{}) error {
 		trader.environment.DatabaseService,
 		trader.environment.AccountService,
 		trader.environment,
-		persistence,
+		persistenceServiceFacade, // if the strategy use persistence facade separately
-		PersistenceServiceFacade, // if the strategy use persistence facade separately
 	)
 }

pkg/notifier/telegramnotifier/logrus_look.go

@@ -34,7 +34,7 @@ func (t *LogHook) Fire(e *logrus.Entry) error {
 	}
 
 	var message = fmt.Sprintf("[%s] %s", e.Level.String(), e.Message)
-	if errData, ok := e.Data[logrus.ErrorKey]; ok {
+	if errData, ok := e.Data[logrus.ErrorKey]; ok && errData != nil {
 		if err, isErr := errData.(error); isErr {
 			message += " Error: " + err.Error()
 		}

pkg/strategy/audacitymaker/strategy.go

@@ -111,7 +111,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	s.orderExecutor.BindTradeStats(s.TradeStats)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 	s.activeOrders = bbgo.NewActiveOrderBook(s.Symbol)

pkg/strategy/bollmaker/strategy.go

@@ -516,7 +516,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	s.orderExecutor.Bind()
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.ExitMethods.Bind(session, s.orderExecutor)
 
@@ -531,7 +531,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 
 	s.OnSuspend(func() {
 		_ = s.orderExecutor.GracefulCancel(ctx)
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 
 	s.OnEmergencyStop(func() {

pkg/strategy/dca/strategy.go

@@ -47,7 +47,6 @@ func (b BudgetPeriod) Duration() time.Duration {
 
 // Strategy is the Dollar-Cost-Average strategy
 type Strategy struct {
-
 	Environment *bbgo.Environment
 	Symbol      string `json:"symbol"`
 	Market      types.Market
@@ -110,7 +109,7 @@ func (s *Strategy) Run(ctx context.Context, _ bbgo.OrderExecutor, session *bbgo.
 	s.orderExecutor.BindEnvironment(s.Environment)
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 

pkg/strategy/drift/strategy.go

@@ -795,7 +795,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.GeneralOrderExecutor.BindProfitStats(s.ProfitStats)
 	s.GeneralOrderExecutor.BindTradeStats(s.TradeStats)
 	s.GeneralOrderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.GeneralOrderExecutor.Bind()
 

pkg/strategy/elliottwave/strategy.go

@@ -310,7 +310,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.GeneralOrderExecutor.BindProfitStats(s.ProfitStats)
 	s.GeneralOrderExecutor.BindTradeStats(s.TradeStats)
 	s.GeneralOrderExecutor.TradeCollector().OnPositionUpdate(func(p *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.GeneralOrderExecutor.Bind()
 

pkg/strategy/ewoDgtrd/strategy.go

@@ -708,7 +708,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	// s.orderExecutor.BindTradeStats(s.TradeStats)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 

pkg/strategy/factorzoo/strategy.go

@@ -109,7 +109,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	s.orderExecutor.BindTradeStats(s.TradeStats)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 	s.activeOrders = bbgo.NewActiveOrderBook(s.Symbol)

pkg/strategy/fmaker/strategy.go

@@ -32,8 +32,6 @@ type IntervalWindowSetting struct {
 }
 
 type Strategy struct {
-	*bbgo.Persistence
-
 	Environment *bbgo.Environment
 	Symbol      string `json:"symbol"`
 	Market      types.Market

pkg/strategy/grid/strategy.go

@@ -19,7 +19,7 @@ const ID = "grid"
 
 var log = logrus.WithField("strategy", ID)
 
-var NotionalModifier = fixedpoint.NewFromFloat(1.0001)
+var notionalModifier = fixedpoint.NewFromFloat(1.0001)
 
 func init() {
 	// Register the pointer of the strategy struct,
@@ -40,13 +40,9 @@ type State struct {
 	// any created orders for tracking trades
 	// [source Order ID] -> arbitrage order
 	ArbitrageOrders map[uint64]types.Order `json:"arbitrageOrders"`
-
-	ProfitStats types.ProfitStats `json:"profitStats,omitempty"`
 }
 
 type Strategy struct {
-	*bbgo.Persistence
-
 	// OrderExecutor is an interface for submitting order.
 	// This field will be injected automatically since it's a single exchange strategy.
 	bbgo.OrderExecutor `json:"-" yaml:"-"`
@@ -88,7 +84,9 @@ type Strategy struct {
 	// Long means you want to hold more base asset than the quote asset.
 	Long bool `json:"long,omitempty" yaml:"long,omitempty"`
 
-	state *State
+	State *State `persistence:"state"`
+
+	ProfitStats *types.ProfitStats `persistence:"profit_stats"`
 
 	// orderStore is used to store all the created orders, so that we can filter the trades.
 	orderStore *bbgo.OrderStore
@@ -199,7 +197,7 @@ func (s *Strategy) generateGridSellOrders(session *bbgo.ExchangeSession) ([]type
 				baseBalance.Available.String())
 		}
 
-		if _, filled := s.state.FilledSellGrids[price]; filled {
+		if _, filled := s.State.FilledSellGrids[price]; filled {
 			log.Debugf("sell grid at price %s is already filled, skipping", price.String())
 			continue
 		}
@@ -216,7 +214,7 @@ func (s *Strategy) generateGridSellOrders(session *bbgo.ExchangeSession) ([]type
 		})
 		baseBalance.Available = baseBalance.Available.Sub(quantity)
 
-		s.state.FilledSellGrids[price] = struct{}{}
+		s.State.FilledSellGrids[price] = struct{}{}
 	}
 
 	return orders, nil
@@ -300,7 +298,7 @@ func (s *Strategy) generateGridBuyOrders(session *bbgo.ExchangeSession) ([]types
 				quoteQuantity)
 		}
 
-		if _, filled := s.state.FilledBuyGrids[price]; filled {
+		if _, filled := s.State.FilledBuyGrids[price]; filled {
 			log.Debugf("buy grid at price %v is already filled, skipping", price)
 			continue
 		}
@@ -317,7 +315,7 @@ func (s *Strategy) generateGridBuyOrders(session *bbgo.ExchangeSession) ([]types
 		})
 		balance.Available = balance.Available.Sub(quoteQuantity)
 
-		s.state.FilledBuyGrids[price] = struct{}{}
+		s.State.FilledBuyGrids[price] = struct{}{}
 	}
 
 	return orders, nil
@@ -416,7 +414,7 @@ func (s *Strategy) handleFilledOrder(filledOrder types.Order) {
 
 	if amount.Compare(s.Market.MinNotional) <= 0 {
 		quantity = bbgo.AdjustFloatQuantityByMinAmount(
-			quantity, price, s.Market.MinNotional.Mul(NotionalModifier))
+			quantity, price, s.Market.MinNotional.Mul(notionalModifier))
 
 		// update amount
 		amount = quantity.Mul(price)
@@ -438,7 +436,7 @@ func (s *Strategy) handleFilledOrder(filledOrder types.Order) {
 
 	// create one-way link from the newly created orders
 	for _, o := range createdOrders {
-		s.state.ArbitrageOrders[o.OrderID] = filledOrder
+		s.State.ArbitrageOrders[o.OrderID] = filledOrder
 	}
 
 	s.orderStore.Add(createdOrders...)
@@ -454,53 +452,53 @@ func (s *Strategy) handleFilledOrder(filledOrder types.Order) {
 	if s.Long {
 		switch filledOrder.Side {
 		case types.SideTypeSell:
-			if buyOrder, ok := s.state.ArbitrageOrders[filledOrder.OrderID]; ok {
+			if buyOrder, ok := s.State.ArbitrageOrders[filledOrder.OrderID]; ok {
 				// use base asset quantity here
 				baseProfit := buyOrder.Quantity.Sub(filledOrder.Quantity)
-				s.state.AccumulativeArbitrageProfit = s.state.AccumulativeArbitrageProfit.
+				s.State.AccumulativeArbitrageProfit = s.State.AccumulativeArbitrageProfit.
 					Add(baseProfit)
 				bbgo.Notify("%s grid arbitrage profit %v %s, accumulative arbitrage profit %v %s",
 					s.Symbol,
 					baseProfit, s.Market.BaseCurrency,
-					s.state.AccumulativeArbitrageProfit, s.Market.BaseCurrency,
+					s.State.AccumulativeArbitrageProfit, s.Market.BaseCurrency,
 				)
 			}
 
 		case types.SideTypeBuy:
-			if sellOrder, ok := s.state.ArbitrageOrders[filledOrder.OrderID]; ok {
+			if sellOrder, ok := s.State.ArbitrageOrders[filledOrder.OrderID]; ok {
 				// use base asset quantity here
 				baseProfit := filledOrder.Quantity.Sub(sellOrder.Quantity)
-				s.state.AccumulativeArbitrageProfit = s.state.AccumulativeArbitrageProfit.Add(baseProfit)
+				s.State.AccumulativeArbitrageProfit = s.State.AccumulativeArbitrageProfit.Add(baseProfit)
 				bbgo.Notify("%s grid arbitrage profit %v %s, accumulative arbitrage profit %v %s",
 					s.Symbol,
 					baseProfit, s.Market.BaseCurrency,
-					s.state.AccumulativeArbitrageProfit, s.Market.BaseCurrency,
+					s.State.AccumulativeArbitrageProfit, s.Market.BaseCurrency,
 				)
 			}
 		}
 	} else if !s.Long && s.Quantity.Sign() > 0 {
 		switch filledOrder.Side {
 		case types.SideTypeSell:
-			if buyOrder, ok := s.state.ArbitrageOrders[filledOrder.OrderID]; ok {
+			if buyOrder, ok := s.State.ArbitrageOrders[filledOrder.OrderID]; ok {
 				// use base asset quantity here
 				quoteProfit := filledOrder.Quantity.Mul(filledOrder.Price).Sub(
 					buyOrder.Quantity.Mul(buyOrder.Price))
-				s.state.AccumulativeArbitrageProfit = s.state.AccumulativeArbitrageProfit.Add(quoteProfit)
+				s.State.AccumulativeArbitrageProfit = s.State.AccumulativeArbitrageProfit.Add(quoteProfit)
 				bbgo.Notify("%s grid arbitrage profit %v %s, accumulative arbitrage profit %v %s",
 					s.Symbol,
 					quoteProfit, s.Market.QuoteCurrency,
-					s.state.AccumulativeArbitrageProfit, s.Market.QuoteCurrency,
+					s.State.AccumulativeArbitrageProfit, s.Market.QuoteCurrency,
 				)
 			}
 		case types.SideTypeBuy:
-			if sellOrder, ok := s.state.ArbitrageOrders[filledOrder.OrderID]; ok {
+			if sellOrder, ok := s.State.ArbitrageOrders[filledOrder.OrderID]; ok {
 				// use base asset quantity here
 				quoteProfit := sellOrder.Quantity.Mul(sellOrder.Price).
 					Sub(filledOrder.Quantity.Mul(filledOrder.Price))
-				s.state.AccumulativeArbitrageProfit = s.state.AccumulativeArbitrageProfit.Add(quoteProfit)
+				s.State.AccumulativeArbitrageProfit = s.State.AccumulativeArbitrageProfit.Add(quoteProfit)
 				bbgo.Notify("%s grid arbitrage profit %v %s, accumulative arbitrage profit %v %s", s.Symbol,
 					quoteProfit, s.Market.QuoteCurrency,
-					s.state.AccumulativeArbitrageProfit, s.Market.QuoteCurrency,
+					s.State.AccumulativeArbitrageProfit, s.Market.QuoteCurrency,
 				)
 			}
 		}
@@ -512,58 +510,29 @@ func (s *Strategy) Subscribe(session *bbgo.ExchangeSession) {
 }
 
 func (s *Strategy) LoadState() error {
-	instanceID := s.InstanceID()
+	if s.State == nil {
-
+		s.State = &State{
-	var state State
+			FilledBuyGrids:  make(map[fixedpoint.Value]struct{}),
-	if s.Persistence != nil {
+			FilledSellGrids: make(map[fixedpoint.Value]struct{}),
-		if err := s.Persistence.Load(&state, ID, instanceID); err != nil {
+			ArbitrageOrders: make(map[uint64]types.Order),
-			if err != service.ErrPersistenceNotExists {
+			Position:        types.NewPositionFromMarket(s.Market),
-				return errors.Wrapf(err, "state load error")
-			}
-
-			s.state = &State{
-				FilledBuyGrids:  make(map[fixedpoint.Value]struct{}),
-				FilledSellGrids: make(map[fixedpoint.Value]struct{}),
-				ArbitrageOrders: make(map[uint64]types.Order),
-				Position:        types.NewPositionFromMarket(s.Market),
-			}
-		} else {
-			s.state = &state
 		}
 	}
 
-	// init profit stats
-	s.state.ProfitStats.Init(s.Market)
-
 	// field guards
-	if s.state.ArbitrageOrders == nil {
+	if s.State.ArbitrageOrders == nil {
-		s.state.ArbitrageOrders = make(map[uint64]types.Order)
+		s.State.ArbitrageOrders = make(map[uint64]types.Order)
 	}
-	if s.state.FilledBuyGrids == nil {
+	if s.State.FilledBuyGrids == nil {
-		s.state.FilledBuyGrids = make(map[fixedpoint.Value]struct{})
+		s.State.FilledBuyGrids = make(map[fixedpoint.Value]struct{})
 	}
-	if s.state.FilledSellGrids == nil {
+	if s.State.FilledSellGrids == nil {
-		s.state.FilledSellGrids = make(map[fixedpoint.Value]struct{})
+		s.State.FilledSellGrids = make(map[fixedpoint.Value]struct{})
 	}
 
 	return nil
 }
 
-func (s *Strategy) SaveState() error {
-	if s.Persistence != nil {
-		log.Infof("backing up grid state...")
-
-		instanceID := s.InstanceID()
-		submitOrders := s.activeOrders.Backup()
-		s.state.Orders = submitOrders
-
-		if err := s.Persistence.Save(s.state, ID, instanceID); err != nil {
-			return err
-		}
-	}
-	return nil
-}
-
 // InstanceID returns the instance identifier from the current grid configuration parameters
 func (s *Strategy) InstanceID() string {
 	return fmt.Sprintf("%s-%s-%d-%d-%d", ID, s.Symbol, s.GridNum, s.UpperPrice.Int(), s.LowerPrice.Int())
@@ -583,11 +552,15 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.groupID = util.FNV32(instanceID)
 	log.Infof("using group id %d from fnv(%s)", s.groupID, instanceID)
 
+	if s.ProfitStats == nil {
+		s.ProfitStats = types.NewProfitStats(s.Market)
+	}
+
 	if err := s.LoadState(); err != nil {
 		return err
 	}
 
-	bbgo.Notify("grid %s position", s.Symbol, s.state.Position)
+	bbgo.Notify("grid %s position", s.Symbol, s.State.Position)
 
 	s.orderStore = bbgo.NewOrderStore(s.Symbol)
 	s.orderStore.BindStream(session.UserDataStream)
@@ -597,11 +570,11 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.activeOrders.OnFilled(s.handleFilledOrder)
 	s.activeOrders.BindStream(session.UserDataStream)
 
-	s.tradeCollector = bbgo.NewTradeCollector(s.Symbol, s.state.Position, s.orderStore)
+	s.tradeCollector = bbgo.NewTradeCollector(s.Symbol, s.State.Position, s.orderStore)
 
 	s.tradeCollector.OnTrade(func(trade types.Trade, profit, netProfit fixedpoint.Value) {
 		bbgo.Notify(trade)
-		s.state.ProfitStats.AddTrade(trade)
+		s.ProfitStats.AddTrade(trade)
 	})
 
 	/*
@@ -622,11 +595,9 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	bbgo.OnShutdown(ctx, func(ctx context.Context, wg *sync.WaitGroup) {
 		defer wg.Done()
 
-		if err := s.SaveState(); err != nil {
+		submitOrders := s.activeOrders.Backup()
-			log.WithError(err).Errorf("can not save state: %+v", s.state)
+		s.State.Orders = submitOrders
-		} else {
+		bbgo.Sync(ctx, s)
-			bbgo.Notify("%s: %s grid is saved", ID, s.Symbol)
-		}
 
 		// now we can cancel the open orders
 		log.Infof("canceling active orders...")
@@ -637,10 +608,10 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 
 	session.UserDataStream.OnStart(func() {
 		// if we have orders in the state data, we can restore them
-		if len(s.state.Orders) > 0 {
+		if len(s.State.Orders) > 0 {
-			bbgo.Notify("restoring %s %d grid orders...", s.Symbol, len(s.state.Orders))
+			bbgo.Notify("restoring %s %d grid orders...", s.Symbol, len(s.State.Orders))
 
-			createdOrders, err := orderExecutor.SubmitOrders(ctx, s.state.Orders...)
+			createdOrders, err := orderExecutor.SubmitOrders(ctx, s.State.Orders...)
 			if err != nil {
 				log.WithError(err).Error("active orders restore error")
 			}

pkg/strategy/irr/strategy.go

@@ -179,7 +179,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 		cumProfit.Update(s.CalcAssetValue(trade.Price).Float64())
 	})
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 	s.activeOrders = bbgo.NewActiveOrderBook(s.Symbol)

pkg/strategy/pivotshort/strategy.go

@@ -165,7 +165,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	s.orderExecutor.BindTradeStats(s.TradeStats)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 

pkg/strategy/rsmaker/strategy.go

@@ -175,7 +175,7 @@ func (s *Strategy) Suspend(ctx context.Context) error {
 		log.WithError(err).Errorf("graceful cancel order error")
 	}
 
-	bbgo.Sync(s)
+	bbgo.Sync(ctx, s)
 	return nil
 }
 
@@ -416,7 +416,7 @@ func (s *Strategy) Run(ctx context.Context, _ bbgo.OrderExecutor, session *bbgo.
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	s.orderExecutor.BindTradeStats(s.TradeStats)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 

pkg/strategy/schedule/strategy.go

@@ -88,7 +88,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	instanceID := s.InstanceID()
 	s.orderExecutor = bbgo.NewGeneralOrderExecutor(session, s.Symbol, ID, instanceID, s.Position)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 

pkg/strategy/skeleton/strategy.go

@@ -104,7 +104,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 		// Update our counter and sync the changes to the persistence layer on time
 		// If you don't do this, BBGO will sync it automatically when BBGO shuts down.
 		s.State.Counter++
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 
 		// To check if we have the quote balance
 		// When symbol = "BTCUSDT", the quote currency is USDT

pkg/strategy/supertrend/strategy.go

@@ -544,14 +544,14 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 
 	// Sync position to redis on trade
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 
 	// StrategyController
 	s.Status = types.StrategyStatusRunning
 	s.OnSuspend(func() {
 		_ = s.orderExecutor.GracefulCancel(ctx)
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.OnEmergencyStop(func() {
 		_ = s.orderExecutor.GracefulCancel(ctx)

pkg/strategy/support/strategy.go

@@ -132,7 +132,6 @@ func (control *TrailingStopControl) GenerateStopOrder(quantity fixedpoint.Value)
 // }
 
 type Strategy struct {
-	*bbgo.Persistence `json:"-"`
 	*bbgo.Environment `json:"-"`
 
 	session *bbgo.ExchangeSession
@@ -176,8 +175,6 @@ type Strategy struct {
 	TradeStats          *types.TradeStats  `persistence:"trade_stats"`
 	CurrentHighestPrice fixedpoint.Value   `persistence:"current_highest_price"`
 
-	state *State
-
 	triggerEMA  *indicator.EWMA
 	longTermEMA *indicator.EWMA
 
@@ -349,7 +346,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.OnSuspend(func() {
 		// Cancel all order
 		_ = s.orderExecutor.GracefulCancel(ctx)
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 
 	s.OnEmergencyStop(func() {

pkg/strategy/trendtrader/strategy.go

@@ -112,7 +112,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	s.orderExecutor.BindProfitStats(s.ProfitStats)
 	s.orderExecutor.BindTradeStats(s.TradeStats)
 	s.orderExecutor.TradeCollector().OnPositionUpdate(func(position *types.Position) {
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	})
 	s.orderExecutor.Bind()
 	s.activeOrders = bbgo.NewActiveOrderBook(s.Symbol)

pkg/strategy/wall/strategy.go

@@ -30,8 +30,6 @@ func init() {
 }
 
 type Strategy struct {
-	*bbgo.Persistence
-
 	Environment          *bbgo.Environment
 	StandardIndicatorSet *bbgo.StandardIndicatorSet
 	Market               types.Market

pkg/strategy/xbalance/strategy.go

@@ -279,7 +279,7 @@ func (s *Strategy) checkBalance(ctx context.Context, sessions map[string]*bbgo.E
 
 		s.State.DailyNumberOfTransfers += 1
 		s.State.DailyAmountOfTransfers = s.State.DailyAmountOfTransfers.Add(requiredAmount)
-		bbgo.Sync(s)
+		bbgo.Sync(ctx, s)
 	}
 }
 

pkg/strategy/xgap/strategy.go

@@ -12,7 +12,6 @@ import (
 
 	"github.com/c9s/bbgo/pkg/bbgo"
 	"github.com/c9s/bbgo/pkg/fixedpoint"
-	"github.com/c9s/bbgo/pkg/service"
 	"github.com/c9s/bbgo/pkg/types"
 	"github.com/c9s/bbgo/pkg/util"
 )
@@ -57,8 +56,6 @@ func (s *State) Reset() {
 }
 
 type Strategy struct {
-	*bbgo.Persistence
-
 	Symbol          string           `json:"symbol"`
 	SourceExchange  string           `json:"sourceExchange"`
 	TradingExchange string           `json:"tradingExchange"`
@@ -73,7 +70,7 @@ type Strategy struct {
 	sourceSession, tradingSession *bbgo.ExchangeSession
 	sourceMarket, tradingMarket   types.Market
 
-	state *State
+	State *State `persistence:"state"`
 
 	mu                                sync.Mutex
 	lastSourceKLine, lastTradingKLine types.KLine
@@ -88,12 +85,12 @@ func (s *Strategy) isBudgetAllowed() bool {
 		return true
 	}
 
-	if s.state.AccumulatedFees == nil {
+	if s.State.AccumulatedFees == nil {
 		return true
 	}
 
 	for asset, budget := range s.DailyFeeBudgets {
-		if fee, ok := s.state.AccumulatedFees[asset]; ok {
+		if fee, ok := s.State.AccumulatedFees[asset]; ok {
 			if fee.Compare(budget) >= 0 {
 				log.Warnf("accumulative fee %s exceeded the fee budget %s, skipping...", fee.String(), budget.String())
 				return false
@@ -111,18 +108,18 @@ func (s *Strategy) handleTradeUpdate(trade types.Trade) {
 		return
 	}
 
-	if s.state.IsOver24Hours() {
+	if s.State.IsOver24Hours() {
-		s.state.Reset()
+		s.State.Reset()
 	}
 
 	// safe check
-	if s.state.AccumulatedFees == nil {
+	if s.State.AccumulatedFees == nil {
-		s.state.AccumulatedFees = make(map[string]fixedpoint.Value)
+		s.State.AccumulatedFees = make(map[string]fixedpoint.Value)
 	}
 
-	s.state.AccumulatedFees[trade.FeeCurrency] = s.state.AccumulatedFees[trade.FeeCurrency].Add(trade.Fee)
+	s.State.AccumulatedFees[trade.FeeCurrency] = s.State.AccumulatedFees[trade.FeeCurrency].Add(trade.Fee)
-	s.state.AccumulatedVolume = s.state.AccumulatedVolume.Add(trade.Quantity)
+	s.State.AccumulatedVolume = s.State.AccumulatedVolume.Add(trade.Quantity)
-	log.Infof("accumulated fee: %s %s", s.state.AccumulatedFees[trade.FeeCurrency].String(), trade.FeeCurrency)
+	log.Infof("accumulated fee: %s %s", s.State.AccumulatedFees[trade.FeeCurrency].String(), trade.FeeCurrency)
 }
 
 func (s *Strategy) CrossSubscribe(sessions map[string]*bbgo.ExchangeSession) {
@@ -172,36 +169,20 @@ func (s *Strategy) CrossRun(ctx context.Context, _ bbgo.OrderExecutionRouter, se
 
 	s.stopC = make(chan struct{})
 
-	var state State
+	if s.State == nil {
-	// load position
+		s.State = &State{}
-	if err := s.Persistence.Load(&state, ID, stateKey); err != nil {
+		s.State.Reset()
-		if err != service.ErrPersistenceNotExists {
+	}
-			return err
-		}
 
-		s.state = &State{}
+	if s.State.IsOver24Hours() {
-		s.state.Reset()
+		log.Warn("state is over 24 hours, resetting to zero")
-	} else {
+		s.State.Reset()
-		// loaded successfully
-		s.state = &state
-		log.Infof("state is restored: %+v", s.state)
-
-		if s.state.IsOver24Hours() {
-			log.Warn("state is over 24 hours, resetting to zero")
-			s.state.Reset()
-		}
 	}
 
 	bbgo.OnShutdown(ctx, func(ctx context.Context, wg *sync.WaitGroup) {
 		defer wg.Done()
-
 		close(s.stopC)
-
+		bbgo.Sync(context.Background(), s)
-		if err := s.Persistence.Save(&s.state, ID, stateKey); err != nil {
-			log.WithError(err).Errorf("can not save state: %+v", s.state)
-		} else {
-			log.Infof("state is saved => %+v", s.state)
-		}
 	})
 
 	// from here, set data binding

pkg/strategy/xmaker/strategy.go

@@ -24,8 +24,6 @@ const priceUpdateTimeout = 30 * time.Second
 
 const ID = "xmaker"
 
-const stateKey = "state-v1"
-
 var log = logrus.WithField("strategy", ID)
 
 func init() {
@@ -33,7 +31,6 @@ func init() {
 }
 
 type Strategy struct {
-	*bbgo.Persistence
 	Environment *bbgo.Environment
 
 	Symbol string `json:"symbol"`
@@ -602,17 +599,6 @@ func (s *Strategy) Validate() error {
 	return nil
 }
 
-func (s *Strategy) LoadState() error {
-	var state State
-
-	// load position
-	if err := s.Persistence.Load(&state, ID, s.Symbol, stateKey); err == nil {
-		s.state = &state
-	}
-
-	return nil
-}
-
 func (s *Strategy) CrossRun(ctx context.Context, orderExecutionRouter bbgo.OrderExecutionRouter, sessions map[string]*bbgo.ExchangeSession) error {
 	if s.BollBandInterval == "" {
 		s.BollBandInterval = types.Interval1m
@@ -704,16 +690,8 @@ func (s *Strategy) CrossRun(ctx context.Context, orderExecutionRouter bbgo.Order
 	s.groupID = util.FNV32(instanceID)
 	log.Infof("using group id %d from fnv(%s)", s.groupID, instanceID)
 
-	if err := s.LoadState(); err != nil {
-		return err
-	}
-
 	if s.Position == nil {
-		if s.state != nil && s.state.Position != nil {
+		s.Position = types.NewPositionFromMarket(s.makerMarket)
-			s.Position = s.state.Position
-		} else {
-			s.Position = types.NewPositionFromMarket(s.makerMarket)
-		}
 
 		// force update for legacy code
 		s.Position.Market = s.makerMarket
@@ -722,14 +700,9 @@ func (s *Strategy) CrossRun(ctx context.Context, orderExecutionRouter bbgo.Order
 	bbgo.Notify("xmaker: %s position is restored", s.Symbol, s.Position)
 
 	if s.ProfitStats == nil {
-		if s.state != nil {
+		s.ProfitStats = &ProfitStats{
-			p2 := s.state.ProfitStats
+			ProfitStats:   types.NewProfitStats(s.makerMarket),
-			s.ProfitStats = &p2
+			MakerExchange: s.makerSession.ExchangeName,
-		} else {
-			s.ProfitStats = &ProfitStats{
-				ProfitStats:   types.NewProfitStats(s.makerMarket),
-				MakerExchange: s.makerSession.ExchangeName,
-			}
 		}
 	}
 

pkg/strategy/xnav/strategy.go

@@ -13,7 +13,6 @@ import (
 	"github.com/slack-go/slack"
 
 	"github.com/c9s/bbgo/pkg/bbgo"
-	"github.com/c9s/bbgo/pkg/service"
 	"github.com/c9s/bbgo/pkg/types"
 	"github.com/c9s/bbgo/pkg/util"
 )
@@ -59,13 +58,13 @@ func (s *State) Reset() {
 }
 
 type Strategy struct {
-	*bbgo.Persistence
 	*bbgo.Environment
 
 	Interval      types.Interval `json:"interval"`
 	ReportOnStart bool           `json:"reportOnStart"`
 	IgnoreDusts   bool           `json:"ignoreDusts"`
-	state         *State
+
+	State *State `persistence:"state"`
 }
 
 func (s *Strategy) ID() string {
@@ -126,64 +125,28 @@ func (s *Strategy) recordNetAssetValue(ctx context.Context, sessions map[string]
 
 	bbgo.Notify(displayAssets)
 
-	if s.state != nil {
+	if s.State != nil {
-		if s.state.IsOver24Hours() {
+		if s.State.IsOver24Hours() {
-			s.state.Reset()
+			s.State.Reset()
 		}
-
+		bbgo.Sync(ctx, s)
-		s.SaveState()
 	}
 }
 
-func (s *Strategy) SaveState() {
-	if err := s.Persistence.Save(s.state, ID, stateKey); err != nil {
-		log.WithError(err).Errorf("%s can not save state: %+v", ID, s.state)
-	} else {
-		log.Infof("%s state is saved: %+v", ID, s.state)
-		// s.Notifiability.Notify("%s %s state is saved", ID, s.Asset, s.state)
-	}
-}
-
-func (s *Strategy) newDefaultState() *State {
-	return &State{}
-}
-
-func (s *Strategy) LoadState() error {
-	var state State
-	if err := s.Persistence.Load(&state, ID, stateKey); err != nil {
-		if err != service.ErrPersistenceNotExists {
-			return err
-		}
-
-		s.state = s.newDefaultState()
-		s.state.Reset()
-	} else {
-		// we loaded it successfully
-		s.state = &state
-
-		// update Asset name for legacy caches
-		// s.state.Asset = s.Asset
-
-		log.Infof("%s state is restored: %+v", ID, s.state)
-		bbgo.Notify("%s state is restored", ID, s.state)
-	}
-
-	return nil
-}
-
 func (s *Strategy) CrossRun(ctx context.Context, _ bbgo.OrderExecutionRouter, sessions map[string]*bbgo.ExchangeSession) error {
 	if s.Interval == "" {
 		return errors.New("interval can not be empty")
 	}
 
-	if err := s.LoadState(); err != nil {
+	if s.State == nil {
-		return err
+		s.State = &State{}
+		s.State.Reset()
 	}
 
 	bbgo.OnShutdown(ctx, func(ctx context.Context, wg *sync.WaitGroup) {
 		defer wg.Done()
 
-		s.SaveState()
+		bbgo.Sync(ctx, s)
 	})
 
 	if s.ReportOnStart {