pivotshort: add MACDDivergence protection

This commit is contained in:
c9s 2022-09-16 01:15:18 +08:00
parent e2dd7c7360
commit 3d7fc75e4b
No known key found for this signature in database
GPG Key ID: 7385E7E464CB0A54
2 changed files with 87 additions and 14 deletions

View File

@ -3,9 +3,13 @@ sessions:
binance:
exchange: binance
envVarPrefix: binance
# uncomment this to enable cross margin
margin: true
isolatedMargin: true
isolatedMarginSymbol: ETHUSDT
# uncomment this to enable isolated margin
# isolatedMargin: true
# isolatedMarginSymbol: ETHUSDT
exchangeStrategies:
- on: binance

View File

@ -4,11 +4,16 @@ import (
"context"
"github.com/c9s/bbgo/pkg/bbgo"
"github.com/c9s/bbgo/pkg/datatype/floats"
"github.com/c9s/bbgo/pkg/fixedpoint"
"github.com/c9s/bbgo/pkg/indicator"
"github.com/c9s/bbgo/pkg/types"
)
type MACDDivergence struct {
*indicator.MACDConfig
}
// FailedBreakHigh -- when price breaks the previous pivot low, we set a trade entry
type FailedBreakHigh struct {
Symbol string
@ -39,8 +44,11 @@ type FailedBreakHigh struct {
TrendEMA *bbgo.TrendEMA `json:"trendEMA"`
MACDConfig *indicator.MACDConfig `json:"macd"`
macd *indicator.MACD
MACDDivergence *MACDDivergence `json:"macdDivergence"`
macd *indicator.MACD
macdTopDivergence bool
lastFailedBreakHigh, lastHigh, lastFastHigh fixedpoint.Value
lastHighInvalidated bool
@ -73,8 +81,8 @@ func (s *FailedBreakHigh) Subscribe(session *bbgo.ExchangeSession) {
session.Subscribe(types.KLineChannel, s.Symbol, types.SubscribeOptions{Interval: s.TrendEMA.Interval})
}
if s.MACDConfig != nil {
session.Subscribe(types.KLineChannel, s.Symbol, types.SubscribeOptions{Interval: s.MACDConfig.Interval})
if s.MACDDivergence != nil {
session.Subscribe(types.KLineChannel, s.Symbol, types.SubscribeOptions{Interval: s.MACDDivergence.Interval})
}
}
@ -104,11 +112,15 @@ func (s *FailedBreakHigh) Bind(session *bbgo.ExchangeSession, orderExecutor *bbg
Window: s.FastWindow,
})
if s.MACDConfig != nil {
s.macd = standardIndicator.MACD(s.MACDConfig.IntervalWindow, s.MACDConfig.ShortPeriod, s.MACDConfig.LongPeriod)
// Experimental: MACD divergence detection
if s.MACDDivergence != nil {
log.Infof("MACD divergence detection is enabled")
s.macd = standardIndicator.MACD(s.MACDDivergence.IntervalWindow, s.MACDDivergence.ShortPeriod, s.MACDDivergence.LongPeriod)
s.macd.OnUpdate(func(macd, signal, histogram float64) {
log.Infof("MACD %+v: macd: %f, signal: %f histogram: %f", s.macd.IntervalWindow, macd, signal, histogram)
s.detectMacdDivergence()
})
s.detectMacdDivergence()
}
if s.VWMA != nil {
@ -194,7 +206,7 @@ func (s *FailedBreakHigh) Bind(session *bbgo.ExchangeSession, orderExecutor *bbg
}
if s.lastHighInvalidated {
log.Infof("%s last high %f is invalidated", s.Symbol, s.lastHigh.Float64())
log.Infof("%s last high %f is invalidated by the fast pivot", s.Symbol, s.lastHigh.Float64())
return
}
@ -233,12 +245,8 @@ func (s *FailedBreakHigh) Bind(session *bbgo.ExchangeSession, orderExecutor *bbg
bbgo.Notify("%s FailedBreakHigh signal detected, closed price %f < breakPrice %f", kline.Symbol, closePrice.Float64(), breakPrice.Float64())
if s.lastFailedBreakHigh.IsZero() || previousHigh.Compare(s.lastFailedBreakHigh) < 0 {
s.lastFailedBreakHigh = previousHigh
}
if position.IsOpened(kline.Close) {
bbgo.Notify("position is already opened, skip")
bbgo.Notify("%s position is already opened, skip", s.Symbol)
return
}
@ -256,6 +264,15 @@ func (s *FailedBreakHigh) Bind(session *bbgo.ExchangeSession, orderExecutor *bbg
}
}
if s.macd != nil && !s.macdTopDivergence {
bbgo.Notify("Detected MACD top divergence")
return
}
if s.lastFailedBreakHigh.IsZero() || previousHigh.Compare(s.lastFailedBreakHigh) < 0 {
s.lastFailedBreakHigh = previousHigh
}
ctx := context.Background()
bbgo.Notify("%s price %f failed breaking the previous high %f with ratio %f, opening short position",
@ -300,6 +317,58 @@ func (s *FailedBreakHigh) pilotQuantityCalculation() {
bbgo.Notify("%s %f quantity will be used for failed break high short", s.Symbol, quantity.Float64())
}
func (s *FailedBreakHigh) detectMacdDivergence() {
s.macdTopDivergence = false
// macdValues := s.macd.Values
histogramValues := s.macd.Histogram
// log.Infof("histogram values: %+v", histogramValues)
pivotWindow := 3
if len(histogramValues) < pivotWindow*2 {
log.Warnf("histogram values is not enough for finding pivots, length=%d", len(histogramValues))
return
}
var histogramPivots floats.Slice
for i := pivotWindow; i > 0 && i < len(histogramValues); i++ {
// find positive histogram and the top
pivot, ok := floats.CalculatePivot(histogramValues[0:i], pivotWindow, pivotWindow, func(a, pivot float64) bool {
return pivot > 0 && pivot > a
})
if ok {
histogramPivots = append(histogramPivots, pivot)
}
}
log.Infof("histogram pivots: %+v", histogramPivots)
// take the last 2-3 pivots to check if there is a divergence
if len(histogramPivots) < 3 {
return
}
histogramPivots = histogramPivots[len(histogramPivots)-3:]
minDiff := 0.01
for i := len(histogramPivots) - 1; i > 0; i-- {
p1 := histogramPivots[i]
p2 := histogramPivots[i-1]
diff := p1 - p2
if diff > -minDiff || diff > minDiff {
continue
}
// negative value = MACD top divergence
if diff < -minDiff {
log.Infof("MACD TOP DIVERGENCE DETECTED: diff %f", diff)
s.macdTopDivergence = true
} else {
s.macdTopDivergence = false
}
return
}
}
func (s *FailedBreakHigh) updatePivotHigh() bool {
high := fixedpoint.NewFromFloat(s.pivotHigh.Last())
if high.IsZero() {