From 4553152ab14ba741953508d88e1c795cf8807016 Mon Sep 17 00:00:00 2001 From: TonyQ Date: Wed, 8 Dec 2021 19:41:14 +0800 Subject: [PATCH] finetune #316 update the makerfile with review opinion and remove yarn.lock in .gitignore --- .gitignore | 1 - Makefile | 12 ++++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.gitignore b/.gitignore index 93a71814a..d117cc776 100644 --- a/.gitignore +++ b/.gitignore @@ -34,4 +34,3 @@ /pkg/server/assets.go node_modules -yarn.lock diff --git a/Makefile b/Makefile index 138840689..3d1ed72b3 100644 --- a/Makefile +++ b/Makefile @@ -24,9 +24,7 @@ $(BIN_DIR): # build native bbgo -bbgo: static bbgo-full - -bbgo-full: +bbgo: static go build -tags web,release -o $(BIN_DIR)/bbgo ./cmd/bbgo # build native bbgo (slim version) @@ -148,9 +146,11 @@ docker-push: docker push yoanlin/bbgo bash -c "[[ -n $(DOCKER_TAG) ]] && docker push yoanlin/bbgo:$(DOCKER_TAG)" -frontend/out/index.html: - cd frontend && yarn install - cd frontend && yarn export +frontend/node_modules: + cd frontend && yarn install + +frontend/out/index.html: frontend/node_modules + cd frontend && yarn export pkg/server/assets.go: frontend/out/index.html go run ./util/embed -package server -output $@ $(FRONTEND_EXPORT_DIR)