From 46329c3a243e845cfee2fff30a233d63b2cd5181 Mon Sep 17 00:00:00 2001
From: c9s <yoanlin93@gmail.com>
Date: Tue, 19 Dec 2023 22:17:33 +0800
Subject: [PATCH] bollmaker: add ema cross signal to bollmaker strategy

---
 config/bollmaker.yaml              |  8 ++++++-
 pkg/strategy/bollmaker/strategy.go | 34 ++++++++++++++++++++++++++++--
 2 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/config/bollmaker.yaml b/config/bollmaker.yaml
index 0cc53894c..d2794d94f 100644
--- a/config/bollmaker.yaml
+++ b/config/bollmaker.yaml
@@ -17,7 +17,7 @@ backtest:
   # see here for more details
   # https://www.investopedia.com/terms/m/maximum-drawdown-mdd.asp
   startTime: "2022-05-01"
-  endTime: "2022-08-14"
+  endTime: "2023-11-01"
   sessions:
   - binance
   symbols:
@@ -200,6 +200,12 @@ exchangeStrategies:
     # buyBelowNeutralSMA: when this set, it will only place buy order when the current price is below the SMA line.
     buyBelowNeutralSMA: true
 
+    emaCross:
+      enabled: true
+      interval: 1h
+      fastWindow: 3
+      slowWindow: 12
+
     exits:
 
     # roiTakeProfit is used to force taking profit by percentage of the position ROI (currently the price change)
diff --git a/pkg/strategy/bollmaker/strategy.go b/pkg/strategy/bollmaker/strategy.go
index a6e3dd8ae..de0b92c13 100644
--- a/pkg/strategy/bollmaker/strategy.go
+++ b/pkg/strategy/bollmaker/strategy.go
@@ -46,9 +46,13 @@ type BollingerSetting struct {
 }
 
 type EMACrossSetting struct {
+	Enabled    bool           `json:"enabled"`
 	Interval   types.Interval `json:"interval"`
 	FastWindow int            `json:"fastWindow"`
 	SlowWindow int            `json:"slowWindow"`
+
+	fastEMA, slowEMA *indicatorv2.EWMAStream
+	cross            *indicatorv2.CrossStream
 }
 
 type Strategy struct {
@@ -174,6 +178,8 @@ type Strategy struct {
 	// neutralBoll is the neutral price section
 	neutralBoll *indicatorv2.BOLLStream
 
+	shouldBuy bool
+
 	// StrategyController
 	bbgo.StrategyController
 }
@@ -280,6 +286,7 @@ func (s *Strategy) placeOrders(ctx context.Context, midPrice fixedpoint.Value, k
 		Price:    askPrice,
 		Market:   s.Market,
 	}
+
 	buyOrder := types.SubmitOrder{
 		Symbol:   s.Symbol,
 		Side:     types.SideTypeBuy,
@@ -438,14 +445,20 @@ func (s *Strategy) placeOrders(ctx context.Context, midPrice fixedpoint.Value, k
 		}
 	}
 
+	if !s.shouldBuy {
+		log.Infof("shouldBuy is turned off, skip placing buy order")
+		canBuy = false
+	}
+
 	if canSell {
 		submitOrders = append(submitOrders, sellOrder)
 	}
+
 	if canBuy {
 		submitOrders = append(submitOrders, buyOrder)
 	}
 
-	// condition for lower the average cost
+	// condition for lowering the average cost
 	/*
 		if midPrice < s.Position.AverageCost.MulFloat64(1.0-s.MinProfitSpread.Float64()) && canBuy {
 			submitOrders = append(submitOrders, buyOrder)
@@ -481,9 +494,26 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	// StrategyController
 	s.Status = types.StrategyStatusRunning
 
+	s.shouldBuy = true
 	s.neutralBoll = session.Indicators(s.Symbol).BOLL(s.NeutralBollinger.IntervalWindow, s.NeutralBollinger.BandWidth)
 	s.defaultBoll = session.Indicators(s.Symbol).BOLL(s.DefaultBollinger.IntervalWindow, s.DefaultBollinger.BandWidth)
 
+	if s.EMACrossSetting != nil && s.EMACrossSetting.Enabled {
+		s.EMACrossSetting.fastEMA = session.Indicators(s.Symbol).EWMA(types.IntervalWindow{Interval: s.Interval, Window: s.EMACrossSetting.FastWindow})
+		s.EMACrossSetting.slowEMA = session.Indicators(s.Symbol).EWMA(types.IntervalWindow{Interval: s.Interval, Window: s.EMACrossSetting.SlowWindow})
+		s.EMACrossSetting.cross = indicatorv2.Cross(s.EMACrossSetting.fastEMA, s.EMACrossSetting.slowEMA)
+		s.EMACrossSetting.cross.OnUpdate(func(v float64) {
+			switch indicatorv2.CrossType(v) {
+			case indicatorv2.CrossOver:
+				s.shouldBuy = true
+			case indicatorv2.CrossUnder:
+				s.shouldBuy = false
+				// TODO: can partially close position when necessary
+				// s.orderExecutor.ClosePosition(ctx)
+			}
+		})
+	}
+
 	// Setup dynamic spread
 	if s.DynamicSpread.IsEnabled() {
 		if s.DynamicSpread.Interval == "" {
@@ -565,7 +595,7 @@ func (s *Strategy) Run(ctx context.Context, orderExecutor bbgo.OrderExecutor, se
 	})
 
 	session.UserDataStream.OnStart(func() {
-		if s.UseTickerPrice {
+		if !bbgo.IsBackTesting && s.UseTickerPrice {
 			ticker, err := s.session.Exchange.QueryTicker(ctx, s.Symbol)
 			if err != nil {
 				return