Merge pull request #1151 from c9s/fix/websocket-reconnect

FIX: types: do not return for normal closure
This commit is contained in:
Yo-An Lin 2023-04-17 16:35:05 +08:00 committed by GitHub
commit 5c33c764da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -203,14 +203,12 @@ func (s *StandardStream) Read(ctx context.Context, conn *websocket.Conn, cancel
// if it's a websocket related error // if it's a websocket related error
case *websocket.CloseError: case *websocket.CloseError:
if err.Code == websocket.CloseNormalClosure { if err.Code != websocket.CloseNormalClosure {
return log.WithError(err).Errorf("websocket error abnormal close: %+v", err)
} }
log.WithError(err).Errorf("websocket error abnormal close: %+v", err)
_ = conn.Close() _ = conn.Close()
// for unexpected close error, we should re-connect // for close error, we should re-connect
// emit reconnect to start a new connection // emit reconnect to start a new connection
s.Reconnect() s.Reconnect()
return return