From 7fdb3f671f2930d1f9680952cdfd6f85d866f309 Mon Sep 17 00:00:00 2001
From: c9s <yoanlin93@gmail.com>
Date: Mon, 26 Aug 2024 12:50:13 +0800
Subject: [PATCH] risk: add Enabled config to circuitbreaker

---
 pkg/risk/circuitbreaker/basic.go | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/pkg/risk/circuitbreaker/basic.go b/pkg/risk/circuitbreaker/basic.go
index e18bfef52..5b5e8430a 100644
--- a/pkg/risk/circuitbreaker/basic.go
+++ b/pkg/risk/circuitbreaker/basic.go
@@ -75,6 +75,8 @@ func init() {
 }
 
 type BasicCircuitBreaker struct {
+	Enabled bool `json:"enabled"`
+
 	MaximumConsecutiveTotalLoss fixedpoint.Value `json:"maximumConsecutiveTotalLoss"`
 
 	MaximumConsecutiveLossTimes int `json:"maximumConsecutiveLossTimes"`
@@ -117,14 +119,17 @@ type BasicCircuitBreaker struct {
 
 func NewBasicCircuitBreaker(strategyID, strategyInstance string) *BasicCircuitBreaker {
 	b := &BasicCircuitBreaker{
+		Enabled:                       true,
 		MaximumConsecutiveLossTimes:   8,
 		MaximumHaltTimes:              3,
 		MaximumHaltTimesExceededPanic: false,
-		HaltDuration:                  types.Duration(1 * time.Hour),
-		strategyID:                    strategyID,
-		strategyInstance:              strategyInstance,
-		metricsLabels:                 prometheus.Labels{"strategy": strategyID, "strategyInstance": strategyInstance},
+
+		HaltDuration:     types.Duration(1 * time.Hour),
+		strategyID:       strategyID,
+		strategyInstance: strategyInstance,
+		metricsLabels:    prometheus.Labels{"strategy": strategyID, "strategyInstance": strategyInstance},
 	}
+
 	b.updateMetrics()
 	return b
 }
@@ -182,7 +187,7 @@ func (b *BasicCircuitBreaker) RecordProfit(profit fixedpoint.Value, now time.Tim
 		b.winRatio = float64(b.winTimes) / float64(b.lossTimes)
 	}
 
-	b.updateMetrics()
+	defer b.updateMetrics()
 
 	if b.MaximumConsecutiveLossTimes > 0 && b.consecutiveLossTimes >= b.MaximumConsecutiveLossTimes {
 		b.halt(now, "exceeded MaximumConsecutiveLossTimes")
@@ -224,6 +229,10 @@ func (b *BasicCircuitBreaker) reset() {
 }
 
 func (b *BasicCircuitBreaker) IsHalted(now time.Time) (string, bool) {
+	if !b.Enabled {
+		return "disabled", false
+	}
+
 	b.mu.Lock()
 	defer b.mu.Unlock()
 
@@ -251,6 +260,8 @@ func (b *BasicCircuitBreaker) halt(now time.Time, reason string) {
 	haltCounterMetrics.With(labels).Set(float64(b.haltCounter))
 	haltMetrics.With(labels).Set(1.0)
 
+	defer b.updateMetrics()
+
 	if b.MaximumHaltTimesExceededPanic && b.haltCounter > b.MaximumHaltTimes {
 		panic(fmt.Errorf("total %d halt times > maximumHaltTimesExceededPanic %d", b.haltCounter, b.MaximumHaltTimes))
 	}