diff --git a/pkg/exchange/binance/convert.go b/pkg/exchange/binance/convert.go index eeee9a1ed..eecbfcd11 100644 --- a/pkg/exchange/binance/convert.go +++ b/pkg/exchange/binance/convert.go @@ -245,15 +245,13 @@ func toGlobalFuturesOrder(futuresOrder *futures.Order, isMargin bool) (*types.Or Price: util.MustParseFloat(futuresOrder.Price), TimeInForce: string(futuresOrder.TimeInForce), }, - Exchange: types.ExchangeBinance, - // IsWorking: futuresOrder.IsWorking, + Exchange: types.ExchangeBinance, OrderID: uint64(futuresOrder.OrderID), Status: toGlobalFuturesOrderStatus(futuresOrder.Status), ExecutedQuantity: util.MustParseFloat(futuresOrder.ExecutedQuantity), CreationTime: types.Time(millisecondTime(futuresOrder.Time)), UpdateTime: types.Time(millisecondTime(futuresOrder.UpdateTime)), IsMargin: isMargin, - // IsIsolated: futuresOrder.IsIsolated, }, nil } diff --git a/pkg/exchange/binance/exchange.go b/pkg/exchange/binance/exchange.go index a115e0e80..3eef126d8 100644 --- a/pkg/exchange/binance/exchange.go +++ b/pkg/exchange/binance/exchange.go @@ -618,9 +618,6 @@ func (e *Exchange) submitFuturesOrder(ctx context.Context, order types.SubmitOrd // use response result format req.NewOrderResponseType(futures.NewOrderRespTypeRESULT) - // if e.IsIsolatedFutures { - // req.IsIsolated(e.IsIsolatedFutures) - // } if len(order.QuantityString) > 0 { req.Quantity(order.QuantityString) @@ -676,14 +673,10 @@ func (e *Exchange) submitFuturesOrder(ctx context.Context, order types.SubmitOrd Price: response.Price, OrigQuantity: response.OrigQuantity, ExecutedQuantity: response.ExecutedQuantity, - // CummulativeQuoteQuantity: response.CummulativeQuoteQuantity, - Status: response.Status, - TimeInForce: response.TimeInForce, - Type: response.Type, - Side: response.Side, - // UpdateTime: response.TransactTime, - // Time: response.TransactTime, - // IsIsolated: response.IsIsolated, + Status: response.Status, + TimeInForce: response.TimeInForce, + Type: response.Type, + Side: response.Side, }, true) return createdOrder, err @@ -796,10 +789,6 @@ func (e *Exchange) submitSpotOrder(ctx context.Context, order types.SubmitOrder) UpdateTime: response.TransactTime, Time: response.TransactTime, IsIsolated: response.IsIsolated, - // StopPrice: - // IcebergQuantity: - // UpdateTime: - // IsWorking: , }, false) return createdOrder, err