From 84dbae159226adcc6bf4d258ada4484bcd8fabbe Mon Sep 17 00:00:00 2001
From: zenix <zenixls2@gmail.com>
Date: Thu, 17 Mar 2022 21:15:25 +0900
Subject: [PATCH] add readme content about testnet, fix code syntax

---
 README.md                        |  9 ++++++
 pkg/exchange/binance/exchange.go |  5 ++--
 pkg/service/sync.go              | 50 +++++++++++++++++---------------
 3 files changed, 38 insertions(+), 26 deletions(-)

diff --git a/README.md b/README.md
index b99e832db..0ae2f1216 100644
--- a/README.md
+++ b/README.md
@@ -173,6 +173,15 @@ bbgo pnl --exchange binance --asset BTC --since "2019-01-01"
 
 ## Advanced Configuration
 
+### Testnet (Paper Trading)
+
+Currently only supports binance testnet.
+To run bbgo in testnet, apply new API keys from [Binance Test Network](https://testnet.binance.vision), and set the following env before you start bbgo:
+```bash
+export PAPER_TRADE=1
+export DISABLE_MARKET_CACHE=1 # the symbols supported in testnet is far less than the mainnet
+```
+
 ### Notification
 
 - [Setting up Telegram notification](./doc/configuration/telegram.md)
diff --git a/pkg/exchange/binance/exchange.go b/pkg/exchange/binance/exchange.go
index 71b38f34a..31ead73dc 100644
--- a/pkg/exchange/binance/exchange.go
+++ b/pkg/exchange/binance/exchange.go
@@ -24,6 +24,7 @@ import (
 
 	"github.com/c9s/bbgo/pkg/fixedpoint"
 	"github.com/c9s/bbgo/pkg/types"
+	"github.com/c9s/bbgo/pkg/util"
 )
 
 const BNB = "BNB"
@@ -61,8 +62,8 @@ func isBinanceUs() bool {
 }
 
 func paperTrade() bool {
-	v, err := strconv.ParseBool(os.Getenv("PAPER_TRADE"))
-	return err == nil && v
+	v, ok := util.GetEnvVarBool("PAPER_TRADE")
+	return ok && v
 }
 
 type Exchange struct {
diff --git a/pkg/service/sync.go b/pkg/service/sync.go
index f19dacaa1..5a072a0a9 100644
--- a/pkg/service/sync.go
+++ b/pkg/service/sync.go
@@ -3,8 +3,6 @@ package service
 import (
 	"context"
 	"errors"
-	"os"
-	"strconv"
 	"time"
 
 	"github.com/c9s/bbgo/pkg/cache"
@@ -12,6 +10,7 @@ import (
 	log "github.com/sirupsen/logrus"
 
 	"github.com/c9s/bbgo/pkg/types"
+	"github.com/c9s/bbgo/pkg/util"
 )
 
 var ErrNotImplemented = errors.New("not implemented")
@@ -26,8 +25,8 @@ type SyncService struct {
 }
 
 func paperTrade() bool {
-	v, err := strconv.ParseBool(os.Getenv("PAPER_TRADE"))
-	return err == nil && v
+	v, ok := util.GetEnvVarBool("PAPER_TRADE")
+	return ok && v
 }
 
 // SyncSessionSymbols syncs the trades from the given exchange session
@@ -51,28 +50,31 @@ func (s *SyncService) SyncSessionSymbols(ctx context.Context, exchange types.Exc
 		}
 	}
 
-	if !paperTrade() {
-		log.Infof("syncing %s deposit records...", exchange.Name())
-		if err := s.DepositService.Sync(ctx, exchange); err != nil {
-			if err != ErrNotImplemented {
-				return err
-			}
-		}
+	if paperTrade() {
+		return nil
+	}
 
-		log.Infof("syncing %s withdraw records...", exchange.Name())
-		if err := s.WithdrawService.Sync(ctx, exchange); err != nil {
-			if err != ErrNotImplemented {
-				return err
-			}
-		}
-
-		log.Infof("syncing %s reward records...", exchange.Name())
-		if err := s.RewardService.Sync(ctx, exchange); err != nil {
-			if err != ErrExchangeRewardServiceNotImplemented {
-				log.Infof("%s reward service is not supported", exchange.Name())
-				return err
-			}
+	log.Infof("syncing %s deposit records...", exchange.Name())
+	if err := s.DepositService.Sync(ctx, exchange); err != nil {
+		if err != ErrNotImplemented {
+			return err
 		}
 	}
+
+	log.Infof("syncing %s withdraw records...", exchange.Name())
+	if err := s.WithdrawService.Sync(ctx, exchange); err != nil {
+		if err != ErrNotImplemented {
+			return err
+		}
+	}
+
+	log.Infof("syncing %s reward records...", exchange.Name())
+	if err := s.RewardService.Sync(ctx, exchange); err != nil {
+		if err != ErrExchangeRewardServiceNotImplemented {
+			log.Infof("%s reward service is not supported", exchange.Name())
+			return err
+		}
+	}
+
 	return nil
 }