Merge pull request #1597 from Newtoniano/close-short-positions

This commit is contained in:
c9s 2024-03-21 09:40:24 +08:00 committed by GitHub
commit abd9f86113
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -517,13 +517,17 @@ func (e *GeneralOrderExecutor) ClosePosition(ctx context.Context, percentage fix
return fmt.Errorf("insufficient base balance, can not sell: %+v", submitOrder) return fmt.Errorf("insufficient base balance, can not sell: %+v", submitOrder)
} }
} else if e.position.IsShort() { } else if e.position.IsShort() {
// TODO: check quote balance here, we also need the current price to validate, need to design.
/*
if quoteBalance, ok := e.session.Account.Balance(e.position.Market.QuoteCurrency); ok { if quoteBalance, ok := e.session.Account.Balance(e.position.Market.QuoteCurrency); ok {
// AdjustQuantityByMaxAmount(submitOrder.Quantity, quoteBalance.Available) ticker, err := e.session.Exchange.QueryTicker(ctx, e.position.Symbol)
// submitOrder.Quantity = fixedpoint.Min(submitOrder.Quantity,) if err != nil {
return err
}
currentPrice := ticker.Sell
submitOrder.Quantity = AdjustQuantityByMaxAmount(submitOrder.Quantity, currentPrice, quoteBalance.Available)
if submitOrder.Quantity.IsZero() {
return fmt.Errorf("insufficient quote balance, can not buy: %+v", submitOrder)
}
} }
*/
} }
} }