From b637d46c83e5300983ce1c5a84a8197f709c7176 Mon Sep 17 00:00:00 2001
From: c9s <yoan@maicoin.com>
Date: Wed, 29 Dec 2021 17:27:37 +0800
Subject: [PATCH] adjust keep alive interval

---
 pkg/exchange/binance/stream.go | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/pkg/exchange/binance/stream.go b/pkg/exchange/binance/stream.go
index 2b1e9652f..3a8f74c32 100644
--- a/pkg/exchange/binance/stream.go
+++ b/pkg/exchange/binance/stream.go
@@ -25,8 +25,8 @@ var debugBinanceDepth bool
 
 var defaultDialer = &websocket.Dialer{
 	Proxy:            http.ProxyFromEnvironment,
-	HandshakeTimeout: 45 * time.Second,
-	ReadBufferSize:   4096 * 2,
+	HandshakeTimeout: 10 * time.Second,
+	ReadBufferSize:   4096,
 }
 
 // from Binance document:
@@ -39,10 +39,8 @@ var defaultDialer = &websocket.Dialer{
 // A PONG frame
 // A JSON controlled message (e.g. subscribe, unsubscribe)
 const readTimeout = 3 * time.Minute
-
-const pongWaitTime = 15 * time.Second
-
-const listenKeyKeepAliveInterval = 1 * time.Minute
+const writeTimeout = 10 * time.Second
+const listenKeyKeepAliveInterval = 10 * time.Minute
 
 func init() {
 	// randomize pulling
@@ -310,6 +308,12 @@ func (s *Stream) dial(listenKey string) (*websocket.Conn, error) {
 	// the connection will be disconnected.
 	// Unsolicited pong frames are allowed.
 	conn.SetPingHandler(nil)
+	conn.SetPongHandler(func(string) error {
+		if err := conn.SetReadDeadline(time.Now().Add(readTimeout * 2)); err != nil {
+			log.WithError(err).Error("pong handler can not set read deadline")
+		}
+		return nil
+	})
 
 	return conn, nil
 }
@@ -417,17 +421,9 @@ func (s *Stream) connect(ctx context.Context) error {
 
 	// create a new context
 	s.connCtx, s.connCancel = context.WithCancel(ctx)
-	conn.SetPongHandler(func(string) error {
-		log.Infof("pong")
-		if err := conn.SetReadDeadline(time.Now().Add(readTimeout * 2)); err != nil {
-			log.WithError(err).Error("pong handler can not set read deadline")
-		}
-		return nil
-	})
 
 	s.Conn = conn
 	s.ConnLock.Unlock()
-
 	s.EmitConnect()
 
 	if !s.PublicOnly {
@@ -456,7 +452,7 @@ func (s *Stream) ping(ctx context.Context) {
 			s.ConnLock.Unlock()
 
 			log.Infof("websocket ping")
-			if err := conn.WriteControl(websocket.PingMessage, nil, time.Now().Add(pongWaitTime)); err != nil {
+			if err := conn.WriteControl(websocket.PingMessage, nil, time.Now().Add(writeTimeout)); err != nil {
 				log.WithError(err).Error("ping error", err)
 				s.Reconnect()
 			}