lychiyu/bbgo_origin
1
0
Fork 0
mirror of https://github.com/c9s/bbgo.git synced 2024-11-14 02:53:50 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

bbgo: fix order executor error message and add price check

Browse Source
This commit is contained in:
c9s 2023-06-06 15:50:07 +08:00
parent ca78a3379a
commit b90564be90
No known key found for this signature in database
GPG Key ID: 7385E7E464CB0A54
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/bbgo/order_executor_general.go
View File

@ -268,7 +268,7 @@ func (e *GeneralOrderExecutor) reduceQuantityAndSubmitOrder(ctx context.Context,
submitOrder.Quantity = q submitOrder.Quantity = q
if e.position.Market.IsDustQuantity(submitOrder.Quantity, price) { if e.position.Market.IsDustQuantity(submitOrder.Quantity, price) {
return nil, types.NewZeroAssetError(fmt.Errorf("dust quantity")) return nil, types.NewZeroAssetError(fmt.Errorf("dust quantity, quantity = %f, price = %f", submitOrder.Quantity.Float64(), price.Float64()))
} }
createdOrder, err2 := e.SubmitOrders(ctx, submitOrder) createdOrder, err2 := e.SubmitOrders(ctx, submitOrder)
@ -334,10 +334,15 @@ func (e *GeneralOrderExecutor) NewOrderFromOpenPosition(ctx context.Context, opt
return nil, err return nil, err
} }
if price.IsZero() {
return nil, errors.New("unable to calculate quantity: zero price given")
}
quantity = quoteQuantity.Div(price) quantity = quoteQuantity.Div(price)
} }
if e.position.Market.IsDustQuantity(quantity, price) { if e.position.Market.IsDustQuantity(quantity, price) {
log.Warnf("dust quantity: %v", quantity) log.Errorf("can not submit order: dust quantity, quantity = %f, price = %f", quantity.Float64(), price.Float64())
return nil, nil return nil, nil
} }
@ -389,9 +394,11 @@ func (e *GeneralOrderExecutor) OpenPosition(ctx context.Context, options OpenPos
if err != nil { if err != nil {
return nil, err return nil, err
} }
if submitOrder == nil { if submitOrder == nil {
return nil, nil return nil, nil
} }
price := options.Price price := options.Price
side := "long" side := "long"
@ -399,7 +406,7 @@ func (e *GeneralOrderExecutor) OpenPosition(ctx context.Context, options OpenPos
side = "short" side = "short"
} }
Notify("Opening %s %s position with quantity %v at price %v", e.position.Symbol, side, submitOrder.Quantity, price) Notify("Opening %s %s position with quantity %f at price %f", e.position.Symbol, side, submitOrder.Quantity.Float64(), price.Float64())
createdOrder, err := e.SubmitOrders(ctx, *submitOrder) createdOrder, err := e.SubmitOrders(ctx, *submitOrder)
if err == nil { if err == nil {