lychiyu/bbgo_origin
1
0
Fork 0
mirror of https://github.com/c9s/bbgo.git synced 2024-11-22 14:55:16 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

binance: fix QueryOrderTrades

Browse Source
This commit is contained in:
c9s 2022-08-12 11:54:04 +08:00
parent b4e71dd5bb
commit c6e4fcf0c2
No known key found for this signature in database
GPG Key ID: 7385E7E464CB0A54
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/exchange/binance/exchange.go
View File

@ -77,7 +77,6 @@ type Exchange struct {
client2 *binanceapi.RestClient
}
var timeSetterOnce sync.Once
func New(key, secret string) *Exchange {
@ -725,7 +724,11 @@ func (e *Exchange) QueryOrderTrades(ctx context.Context, q types.OrderQuery) ([]
return nil, err
}
remoteTrades, err := e.client.NewListTradesService().OrderId(orderID).Do(ctx)
if len(q.Symbol) == 0 {
return nil, errors.New("binance: symbol parameter is a mandatory parameter for querying order trades")
}
remoteTrades, err := e.client.NewListTradesService().Symbol(q.Symbol).OrderId(orderID).Do(ctx)
if err != nil {
return nil, err
}
@ -734,7 +737,7 @@ func (e *Exchange) QueryOrderTrades(ctx context.Context, q types.OrderQuery) ([]
for _, t := range remoteTrades {
localTrade, err := toGlobalTrade(*t, e.IsMargin)
if err != nil {
log.WithError(err).Errorf("can not convert binance trade: %+v", t)
log.WithError(err).Errorf("binance: can not convert trade: %+v", t)
continue
}