From ba913ce4debe8583dc0de2d5f6b69449802bee62 Mon Sep 17 00:00:00 2001 From: Lan Phan Date: Tue, 3 Sep 2024 00:38:17 +0700 Subject: [PATCH] update timeInForce for binance margin order --- pkg/exchange/binance/exchange.go | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/pkg/exchange/binance/exchange.go b/pkg/exchange/binance/exchange.go index 90decc6bf..132ea5b3f 100644 --- a/pkg/exchange/binance/exchange.go +++ b/pkg/exchange/binance/exchange.go @@ -1005,16 +1005,13 @@ func (e *Exchange) submitMarginOrder(ctx context.Context, order types.SubmitOrde } } - // could be IOC or FOK - switch order.Type { - case types.OrderTypeLimit, types.OrderTypeStopLimit: - req.TimeInForce(binance.TimeInForceTypeGTC) - case types.OrderTypeLimitMaker: - // do not set TimeInForce for LimitMaker - default: - if len(order.TimeInForce) > 0 { - // TODO: check the TimeInForce value - req.TimeInForce(binance.TimeInForceType(order.TimeInForce)) + if len(order.TimeInForce) > 0 { + // TODO: check the TimeInForce value + req.TimeInForce(binance.TimeInForceType(order.TimeInForce)) + } else { + switch order.Type { + case types.OrderTypeLimit, types.OrderTypeStopLimit: + req.TimeInForce(binance.TimeInForceTypeGTC) } }