lychiyu/bbgo_origin
1
0
Fork 0
mirror of https://github.com/c9s/bbgo.git synced 2024-11-22 14:55:16 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #367 from austin362667/main

Browse Source 
binance: remove comments not support isolated futures
This commit is contained in:
Yo-An Lin 2021-12-15 00:59:42 +08:00 committed by GitHub
commit f315d9f348
2 changed files with 5 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/exchange/binance/convert.go
View File

@ -245,15 +245,13 @@ func toGlobalFuturesOrder(futuresOrder *futures.Order, isMargin bool) (*types.Or
Price: util.MustParseFloat(futuresOrder.Price),
TimeInForce: string(futuresOrder.TimeInForce),
},
Exchange: types.ExchangeBinance,
// IsWorking: futuresOrder.IsWorking,
Exchange: types.ExchangeBinance,
OrderID: uint64(futuresOrder.OrderID),
Status: toGlobalFuturesOrderStatus(futuresOrder.Status),
ExecutedQuantity: util.MustParseFloat(futuresOrder.ExecutedQuantity),
CreationTime: types.Time(millisecondTime(futuresOrder.Time)),
UpdateTime: types.Time(millisecondTime(futuresOrder.UpdateTime)),
IsMargin: isMargin,
// IsIsolated: futuresOrder.IsIsolated,
}, nil
}

19
pkg/exchange/binance/exchange.go
View File

@ -618,9 +618,6 @@ func (e *Exchange) submitFuturesOrder(ctx context.Context, order types.SubmitOrd
// use response result format
req.NewOrderResponseType(futures.NewOrderRespTypeRESULT)
// if e.IsIsolatedFutures {
// req.IsIsolated(e.IsIsolatedFutures)
// }
if len(order.QuantityString) > 0 {
req.Quantity(order.QuantityString)
@ -676,14 +673,10 @@ func (e *Exchange) submitFuturesOrder(ctx context.Context, order types.SubmitOrd
Price: response.Price,
OrigQuantity: response.OrigQuantity,
ExecutedQuantity: response.ExecutedQuantity,
// CummulativeQuoteQuantity: response.CummulativeQuoteQuantity,
Status: response.Status,
TimeInForce: response.TimeInForce,
Type: response.Type,
Side: response.Side,
// UpdateTime: response.TransactTime,
// Time: response.TransactTime,
// IsIsolated: response.IsIsolated,
Status: response.Status,
TimeInForce: response.TimeInForce,
Type: response.Type,
Side: response.Side,
}, true)
return createdOrder, err
@ -796,10 +789,6 @@ func (e *Exchange) submitSpotOrder(ctx context.Context, order types.SubmitOrder)
UpdateTime: response.TransactTime,
Time: response.TransactTime,
IsIsolated: response.IsIsolated,
// StopPrice:
// IcebergQuantity:
// UpdateTime:
// IsWorking: ,
}, false)
return createdOrder, err