Merge pull request #6331 from samgermain/todo

Todo-levs
This commit is contained in:
Matthias 2022-01-31 15:42:45 +01:00 committed by GitHub
commit 1b063739c0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 4 deletions

View File

@ -567,8 +567,7 @@ class LocalTrade():
elif order_type in ('market', 'limit') and self.exit_side == order['side']: elif order_type in ('market', 'limit') and self.exit_side == order['side']:
if self.is_open: if self.is_open:
payment = "BUY" if self.is_short else "SELL" payment = "BUY" if self.is_short else "SELL"
# TODO-lev: On shorts, you buy a little bit more than the amount (amount + interest) # * On margin shorts, you buy a little bit more than the amount (amount + interest)
# TODO-lev: This wll only print the original amount
logger.info(f'{order_type.upper()}_{payment} has been fulfilled for {self}.') logger.info(f'{order_type.upper()}_{payment} has been fulfilled for {self}.')
# TODO-lev: Double check this # TODO-lev: Double check this
self.close(safe_value_fallback(order, 'average', 'price')) self.close(safe_value_fallback(order, 'average', 'price'))

View File

@ -1014,8 +1014,7 @@ def get_markets():
'percentage': True, 'percentage': True,
'taker': 0.0006, 'taker': 0.0006,
'maker': 0.0002, 'maker': 0.0002,
# TODO-lev: `contractSize` should be numeric - this is an open bug in ccxt. 'contractSize': 10,
'contractSize': '10',
'active': True, 'active': True,
'expiry': None, 'expiry': None,
'expiryDatetime': None, 'expiryDatetime': None,