From 912e9bd15ceb584ada3e70ac55883da760928cc6 Mon Sep 17 00:00:00 2001
From: misagh <misagh.shakeri@gmail.com>
Date: Thu, 11 Oct 2018 19:12:12 +0200
Subject: [PATCH 1/3] mac installation path

---
 docs/installation.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/installation.md b/docs/installation.md
index 1000600e6..482209933 100644
--- a/docs/installation.md
+++ b/docs/installation.md
@@ -268,7 +268,7 @@ wget http://prdownloads.sourceforge.net/ta-lib/ta-lib-0.4.0-src.tar.gz
 tar xvzf ta-lib-0.4.0-src.tar.gz
 cd ta-lib
 sed -i.bak "s|0.00000001|0.000000000000000001 |g" src/ta_func/ta_utility.h
-./configure --prefix=/usr
+./configure --prefix=/usr # On MacOS this should be --prefix=/usr/local
 make
 make install
 cd ..

From fb3fd7cb152f399e8aa1ae96315658ab953407b6 Mon Sep 17 00:00:00 2001
From: misagh <misagh.shakeri@gmail.com>
Date: Thu, 11 Oct 2018 19:26:19 +0200
Subject: [PATCH 2/3] setup script and documentation fixed for TA-Lib and MacOS

---
 docs/installation.md |  6 +++---
 setup.sh             | 10 +++++++---
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/docs/installation.md b/docs/installation.md
index 482209933..d2002035e 100644
--- a/docs/installation.md
+++ b/docs/installation.md
@@ -251,7 +251,7 @@ python3 -m pip install -e .
 
 ### MacOS
 
-#### Install Python 3.6, git, wget and ta-lib
+#### Install Python 3.6, git and wget
 
 ```bash
 brew install python3 git wget
@@ -268,9 +268,9 @@ wget http://prdownloads.sourceforge.net/ta-lib/ta-lib-0.4.0-src.tar.gz
 tar xvzf ta-lib-0.4.0-src.tar.gz
 cd ta-lib
 sed -i.bak "s|0.00000001|0.000000000000000001 |g" src/ta_func/ta_utility.h
-./configure --prefix=/usr # On MacOS this should be --prefix=/usr/local
+./configure --prefix=/usr/local
 make
-make install
+sudo make install
 cd ..
 rm -rf ./ta-lib*
 ```
diff --git a/setup.sh b/setup.sh
index bd58edbee..472260148 100755
--- a/setup.sh
+++ b/setup.sh
@@ -37,7 +37,11 @@ function updateenv () {
 function install_talib () {
     curl -O -L http://prdownloads.sourceforge.net/ta-lib/ta-lib-0.4.0-src.tar.gz
     tar zxvf ta-lib-0.4.0-src.tar.gz
-    cd ta-lib && ./configure --prefix=/usr && make && sudo make install
+    cd ta-lib
+    sed -i.bak "s|0.00000001|0.000000000000000001 |g" src/ta_func/ta_utility.h
+    ./configure --prefix=/usr/local
+    make
+    sudo make install
     cd .. && rm -rf ./ta-lib*
 }
 
@@ -50,8 +54,8 @@ function install_macos () {
         echo "-------------------------"
         /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
     fi
-    brew install python3 wget ta-lib
-
+    brew install python3 wget
+    install_talib
     test_and_fix_python_on_mac
 }
 

From b09a1d1abed8ce828e40166f00e8c7bf3d28f6a8 Mon Sep 17 00:00:00 2001
From: misagh <misagh.shakeri@gmail.com>
Date: Tue, 23 Oct 2018 19:36:57 +0200
Subject: [PATCH 3/3] 1) do not download ta-lib as we have it offline.  2)
 removing ta-lib directory but not the file

---
 setup.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/setup.sh b/setup.sh
index 472260148..1bb2ba397 100755
--- a/setup.sh
+++ b/setup.sh
@@ -35,14 +35,13 @@ function updateenv () {
 
 # Install tab lib
 function install_talib () {
-    curl -O -L http://prdownloads.sourceforge.net/ta-lib/ta-lib-0.4.0-src.tar.gz
     tar zxvf ta-lib-0.4.0-src.tar.gz
     cd ta-lib
     sed -i.bak "s|0.00000001|0.000000000000000001 |g" src/ta_func/ta_utility.h
     ./configure --prefix=/usr/local
     make
     sudo make install
-    cd .. && rm -rf ./ta-lib*
+    cd .. && rm -rf ./ta-lib/
 }
 
 # Install bot MacOS