reload_trade should be a post endpoint

This commit is contained in:
Matthias 2023-05-16 20:27:07 +02:00
parent 63294c4d3a
commit 45ee12e257
2 changed files with 5 additions and 4 deletions

View File

@ -45,7 +45,8 @@ logger = logging.getLogger(__name__)
# 2.25: Add several profit values to /status endpoint # 2.25: Add several profit values to /status endpoint
# 2.26: increase /balance output # 2.26: increase /balance output
# 2.27: Add /trades/<id>/reload endpoint # 2.27: Add /trades/<id>/reload endpoint
API_VERSION = 2.27 # 2.28: Switch reload endpoint to Post
API_VERSION = 2.28
# Public API, requires no auth. # Public API, requires no auth.
router_public = APIRouter() router_public = APIRouter()
@ -133,7 +134,7 @@ def trade_cancel_open_order(tradeid: int, rpc: RPC = Depends(get_rpc)):
return rpc._rpc_trade_status([tradeid])[0] return rpc._rpc_trade_status([tradeid])[0]
@router.get('/trades/{tradeid}/reload', response_model=OpenTradeSchema, tags=['trading']) @router.post('/trades/{tradeid}/reload', response_model=OpenTradeSchema, tags=['trading'])
def trade_reload(tradeid: int, rpc: RPC = Depends(get_rpc)): def trade_reload(tradeid: int, rpc: RPC = Depends(get_rpc)):
rpc._rpc_reload_trade_from_exchange(tradeid) rpc._rpc_reload_trade_from_exchange(tradeid)
return rpc._rpc_trade_status([tradeid])[0] return rpc._rpc_trade_status([tradeid])[0]

View File

@ -755,7 +755,7 @@ def test_api_trade_reload_trade(botclient, mocker, fee, markets, ticker, is_shor
cancel_stoploss_order=stoploss_mock, cancel_stoploss_order=stoploss_mock,
) )
rc = client_get(client, f"{BASE_URI}/trades/10/reload") rc = client_post(client, f"{BASE_URI}/trades/10/reload")
assert_response(rc, 502) assert_response(rc, 502)
assert 'Could not find trade with id 10.' in rc.json()['error'] assert 'Could not find trade with id 10.' in rc.json()['error']
assert ftbot.handle_onexchange_order.call_count == 0 assert ftbot.handle_onexchange_order.call_count == 0
@ -763,7 +763,7 @@ def test_api_trade_reload_trade(botclient, mocker, fee, markets, ticker, is_shor
create_mock_trades(fee, is_short=is_short) create_mock_trades(fee, is_short=is_short)
Trade.commit() Trade.commit()
rc = client_get(client, f"{BASE_URI}/trades/5/reload") rc = client_post(client, f"{BASE_URI}/trades/5/reload")
assert ftbot.handle_onexchange_order.call_count == 1 assert ftbot.handle_onexchange_order.call_count == 1