small PR conversation resolutions

This commit is contained in:
robcaulk 2022-07-22 17:46:14 +02:00
parent 40f00196eb
commit 5559e605b8
3 changed files with 4 additions and 3 deletions

View File

@ -511,7 +511,7 @@ class IFreqaiModel(ABC):
""" """
@abstractmethod @abstractmethod
def fit(self) -> Any: def fit(self, data_dictionary: Dict[str, Any]) -> Any:
""" """
Most regressors use the same function names and arguments e.g. user Most regressors use the same function names and arguments e.g. user
can drop in LGBMRegressor in place of CatBoostRegressor and all data can drop in LGBMRegressor in place of CatBoostRegressor and all data

View File

@ -44,7 +44,7 @@ class FreqaiModelResolver(IResolver):
) )
if freqaimodel_name in disallowed_models: if freqaimodel_name in disallowed_models:
raise OperationalException( raise OperationalException(
f"{freqaimodel_name} is a baseclass and cannot be used directly. User must choose " f"{freqaimodel_name} is a baseclass and cannot be used directly. Please choose "
"an existing child class or inherit from this baseclass.\n" "an existing child class or inherit from this baseclass.\n"
) )
freqaimodel = FreqaiModelResolver.load_object( freqaimodel = FreqaiModelResolver.load_object(

View File

@ -555,7 +555,8 @@ class IStrategy(ABC, HyperStrategyMixin):
Function designed to automatically generate, name and merge features Function designed to automatically generate, name and merge features
from user indicated timeframes in the configuration file. User can add from user indicated timeframes in the configuration file. User can add
additional features here, but must follow the naming convention. additional features here, but must follow the naming convention.
Defined in IStrategy because Freqai needs to know it exists. This method is *only* used in FreqaiDataKitchen class and therefore
it is only called if FreqAI is active.
:params: :params:
:pair: pair to be used as informative :pair: pair to be used as informative
:df: strategy dataframe which will receive merges from informatives :df: strategy dataframe which will receive merges from informatives