mirror of
https://github.com/freqtrade/freqtrade.git
synced 2024-11-10 18:23:55 +00:00
a8d56b2850
verifying that either max_open_trades or stake_amount is set for operations without edge
159 lines
5.7 KiB
Python
159 lines
5.7 KiB
Python
import logging
|
|
from typing import Any, Dict
|
|
|
|
from jsonschema import Draft4Validator, validators
|
|
from jsonschema.exceptions import ValidationError, best_match
|
|
|
|
from freqtrade import constants
|
|
from freqtrade.exceptions import OperationalException
|
|
from freqtrade.state import RunMode
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def _extend_validator(validator_class):
|
|
"""
|
|
Extended validator for the Freqtrade configuration JSON Schema.
|
|
Currently it only handles defaults for subschemas.
|
|
"""
|
|
validate_properties = validator_class.VALIDATORS['properties']
|
|
|
|
def set_defaults(validator, properties, instance, schema):
|
|
for prop, subschema in properties.items():
|
|
if 'default' in subschema:
|
|
instance.setdefault(prop, subschema['default'])
|
|
|
|
for error in validate_properties(
|
|
validator, properties, instance, schema,
|
|
):
|
|
yield error
|
|
|
|
return validators.extend(
|
|
validator_class, {'properties': set_defaults}
|
|
)
|
|
|
|
|
|
FreqtradeValidator = _extend_validator(Draft4Validator)
|
|
|
|
|
|
def validate_config_schema(conf: Dict[str, Any]) -> Dict[str, Any]:
|
|
"""
|
|
Validate the configuration follow the Config Schema
|
|
:param conf: Config in JSON format
|
|
:return: Returns the config if valid, otherwise throw an exception
|
|
"""
|
|
try:
|
|
FreqtradeValidator(constants.CONF_SCHEMA).validate(conf)
|
|
return conf
|
|
except ValidationError as e:
|
|
logger.critical(
|
|
f"Invalid configuration. See config.json.example. Reason: {e}"
|
|
)
|
|
raise ValidationError(
|
|
best_match(Draft4Validator(constants.CONF_SCHEMA).iter_errors(conf)).message
|
|
)
|
|
|
|
|
|
def validate_config_consistency(conf: Dict[str, Any]) -> None:
|
|
"""
|
|
Validate the configuration consistency.
|
|
Should be ran after loading both configuration and strategy,
|
|
since strategies can set certain configuration settings too.
|
|
:param conf: Config in JSON format
|
|
:return: Returns None if everything is ok, otherwise throw an OperationalException
|
|
"""
|
|
|
|
# validating trailing stoploss
|
|
_validate_trailing_stoploss(conf)
|
|
_validate_edge(conf)
|
|
_validate_whitelist(conf)
|
|
_validate_unlimited_amount(conf)
|
|
|
|
# validate configuration before returning
|
|
logger.info('Validating configuration ...')
|
|
validate_config_schema(conf)
|
|
|
|
|
|
def _validate_unlimited_amount(conf: Dict[str, Any]) -> None:
|
|
"""
|
|
If edge is disabled, either max_open_trades or stake_amount need to be set.
|
|
:raise: OperationalException if config validation failed
|
|
"""
|
|
if (not conf.get('edge', {}).get('enabled')
|
|
and conf.get('max_open_trades') == float('inf')
|
|
and conf.get('stake_amount') == constants.UNLIMITED_STAKE_AMOUNT):
|
|
raise OperationalException("`max_open_trades` and `stake_amount` cannot both be unlimited.")
|
|
|
|
|
|
def _validate_trailing_stoploss(conf: Dict[str, Any]) -> None:
|
|
|
|
if conf.get('stoploss') == 0.0:
|
|
raise OperationalException(
|
|
'The config stoploss needs to be different from 0 to avoid problems with sell orders.'
|
|
)
|
|
# Skip if trailing stoploss is not activated
|
|
if not conf.get('trailing_stop', False):
|
|
return
|
|
|
|
tsl_positive = float(conf.get('trailing_stop_positive', 0))
|
|
tsl_offset = float(conf.get('trailing_stop_positive_offset', 0))
|
|
tsl_only_offset = conf.get('trailing_only_offset_is_reached', False)
|
|
|
|
if tsl_only_offset:
|
|
if tsl_positive == 0.0:
|
|
raise OperationalException(
|
|
'The config trailing_only_offset_is_reached needs '
|
|
'trailing_stop_positive_offset to be more than 0 in your config.')
|
|
if tsl_positive > 0 and 0 < tsl_offset <= tsl_positive:
|
|
raise OperationalException(
|
|
'The config trailing_stop_positive_offset needs '
|
|
'to be greater than trailing_stop_positive in your config.')
|
|
|
|
# Fetch again without default
|
|
if 'trailing_stop_positive' in conf and float(conf['trailing_stop_positive']) == 0.0:
|
|
raise OperationalException(
|
|
'The config trailing_stop_positive needs to be different from 0 '
|
|
'to avoid problems with sell orders.'
|
|
)
|
|
|
|
|
|
def _validate_edge(conf: Dict[str, Any]) -> None:
|
|
"""
|
|
Edge and Dynamic whitelist should not both be enabled, since edge overrides dynamic whitelists.
|
|
"""
|
|
|
|
if not conf.get('edge', {}).get('enabled'):
|
|
return
|
|
|
|
if conf.get('pairlist', {}).get('method') == 'VolumePairList':
|
|
raise OperationalException(
|
|
"Edge and VolumePairList are incompatible, "
|
|
"Edge will override whatever pairs VolumePairlist selects."
|
|
)
|
|
|
|
|
|
def _validate_whitelist(conf: Dict[str, Any]) -> None:
|
|
"""
|
|
Dynamic whitelist does not require pair_whitelist to be set - however StaticWhitelist does.
|
|
"""
|
|
if conf.get('runmode', RunMode.OTHER) in [RunMode.OTHER, RunMode.PLOT,
|
|
RunMode.UTIL_NO_EXCHANGE, RunMode.UTIL_EXCHANGE]:
|
|
return
|
|
|
|
for pl in conf.get('pairlists', [{'method': 'StaticPairList'}]):
|
|
if (pl.get('method') == 'StaticPairList'
|
|
and not conf.get('exchange', {}).get('pair_whitelist')):
|
|
raise OperationalException("StaticPairList requires pair_whitelist to be set.")
|
|
|
|
if pl.get('method') == 'StaticPairList':
|
|
stake = conf['stake_currency']
|
|
invalid_pairs = []
|
|
for pair in conf['exchange'].get('pair_whitelist'):
|
|
if not pair.endswith(f'/{stake}'):
|
|
invalid_pairs.append(pair)
|
|
|
|
if invalid_pairs:
|
|
raise OperationalException(
|
|
f"Stake-currency '{stake}' not compatible with pair-whitelist. "
|
|
f"Please remove the following pairs: {invalid_pairs}")
|