From 41f464e4ca6685b702ba3c254035918d10a61550 Mon Sep 17 00:00:00 2001 From: Matthias Date: Sat, 21 Oct 2023 17:11:38 +0200 Subject: [PATCH] Improve error failure case handling --- src/shared/formatters/pairFormat.ts | 1 + tests/unit/formatPair.spec.ts | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/shared/formatters/pairFormat.ts b/src/shared/formatters/pairFormat.ts index 3b28d7c3..a4e33a7d 100644 --- a/src/shared/formatters/pairFormat.ts +++ b/src/shared/formatters/pairFormat.ts @@ -4,6 +4,7 @@ * @returns {stakeCurrency, quoteCurrency} */ export function splitTradePair(pair: string): { stakeCurrency: string; quoteCurrency: string } { + if (!pair) return { stakeCurrency: '', quoteCurrency: '' }; const [stakeCurrency, quoteCurrency] = pair.split('/'); const quoteCurrencySplit = quoteCurrency.split(':'); return { stakeCurrency, quoteCurrency: quoteCurrencySplit[0] || quoteCurrency }; diff --git a/tests/unit/formatPair.spec.ts b/tests/unit/formatPair.spec.ts index d70e28fa..2488832b 100644 --- a/tests/unit/formatPair.spec.ts +++ b/tests/unit/formatPair.spec.ts @@ -23,4 +23,7 @@ describe('splitTradePair', () => { quoteCurrency: 'USDT', }); }); + it('Does not fail on empty input', () => { + expect(splitTradePair('')).toEqual({ stakeCurrency: '', quoteCurrency: '' }); + }); });