From c3a4f1def6fe169df309bceaab16553ed3af170c Mon Sep 17 00:00:00 2001
From: Matthias <xmatthias@outlook.com>
Date: Sat, 10 Jun 2023 08:46:36 +0200
Subject: [PATCH] Make parameter types more explicit

---
 src/components/ftbot/PairlistConfigItem.vue |  7 ++---
 src/stores/pairlistConfig.ts                |  3 +-
 src/types/pairlists.ts                      | 34 +++++++++++++++++++--
 3 files changed, 37 insertions(+), 7 deletions(-)

diff --git a/src/components/ftbot/PairlistConfigItem.vue b/src/components/ftbot/PairlistConfigItem.vue
index c58b20e9..da798418 100644
--- a/src/components/ftbot/PairlistConfigItem.vue
+++ b/src/components/ftbot/PairlistConfigItem.vue
@@ -55,11 +55,10 @@
 </template>
 
 <script setup lang="ts">
-import { Pairlist } from '@/types';
-import { ref } from 'vue';
-import PairlistConfigParameter from './PairlistConfigParameter.vue';
-import { computed } from 'vue';
+import PairlistConfigParameter from '@/components/ftbot/PairlistConfigParameter.vue';
 import { usePairlistConfigStore } from '@/stores/pairlistConfig';
+import { Pairlist } from '@/types';
+import { computed, ref } from 'vue';
 
 const pairlistStore = usePairlistConfigStore();
 
diff --git a/src/stores/pairlistConfig.ts b/src/stores/pairlistConfig.ts
index f11b05ce..84fdd793 100644
--- a/src/stores/pairlistConfig.ts
+++ b/src/stores/pairlistConfig.ts
@@ -7,6 +7,7 @@ import {
   Pairlist,
   PairlistConfig,
   PairlistParamType,
+  PairlistParamValue,
   PairlistPayloadItem,
   PairlistsPayload,
   TradingMode,
@@ -165,7 +166,7 @@ export const usePairlistConfigStore = defineStore(
       }
     }
 
-    function convertToParamType(type: PairlistParamType, value: string) {
+    function convertToParamType(type: PairlistParamType, value: PairlistParamValue) {
       if (type === PairlistParamType.number) {
         return Number(value);
       } else if (type === PairlistParamType.boolean) {
diff --git a/src/types/pairlists.ts b/src/types/pairlists.ts
index f5b0998d..a4308557 100644
--- a/src/types/pairlists.ts
+++ b/src/types/pairlists.ts
@@ -31,15 +31,45 @@ export enum PairlistParamType {
   option = 'option',
 }
 
-export interface PairlistParameter {
+export type PairlistParamValue = string | number | boolean;
+
+interface PairlistParameterBase {
   description: string;
   help: string;
   type: PairlistParamType;
+}
+
+export interface StringPairlistParameter extends PairlistParameterBase {
+  type: PairlistParamType.string;
   value?: string;
   default: string;
-  options?: string[];
 }
 
+export interface NumberPairlistParameter extends PairlistParameterBase {
+  type: PairlistParamType.number;
+  value?: number;
+  default: number;
+}
+
+export interface BooleanPairlistParameter extends PairlistParameterBase {
+  type: PairlistParamType.boolean;
+  value?: boolean;
+  default: boolean;
+}
+
+export interface OptionPairlistParameter extends PairlistParameterBase {
+  type: PairlistParamType.option;
+  options: string[];
+  value?: string;
+  default: string;
+}
+
+export type PairlistParameter =
+  | StringPairlistParameter
+  | NumberPairlistParameter
+  | BooleanPairlistParameter
+  | OptionPairlistParameter;
+
 export interface PairlistPayloadItem {
   method: string;
   [key: string]: string | number | boolean;